> This might be just a minor issue. I noticed that NFS_MOUNT_FSCACHE is > defined as an integer with two bits on as shown here. > > #define NFS_MOUNT_SECFLAVOUR 0x2000 /* 5 */ > +#define NFS_MOUNT_FSCACHE 0x3000 > > This is true for both userland and kernel space as it should. I know > this would work fine but it overlaps with the bit for > NFS_MOUNT_SECFLAVOUR. Could NFS_MOUNT_FSCACHE be defined as 0x4000? I > am wondering if there is anything particular about this. The other bit also overlaps, with NFS_MOUNT_STRICTLOCK: http://people.redhat.com/steved/cachefs/2.6.13-rc3-mm1/2.6.13-rc3-mm1-nfs-fscache.patch #define NFS_MOUNT_NOACL 0x0800 /* 4 */ #define NFS_MOUNT_STRICTLOCK 0x1000 /* reserved for NFSv4 */ #define NFS_MOUNT_SECFLAVOUR 0x2000 /* 5 */ +#define NFS_MOUNT_FSCACHE 0x3000 #define NFS_MOUNT_FLAGMASK 0xFFFF So here it makes more impression of a bug created by a slip of mind, counting "1 2 3" instead of correct "1 2 4" ? Vaclav
