Hi Luiz
On Mon, 4 Apr 2022 at 23:19, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
>
> Hi Adam,
>
> On Mon, Apr 4, 2022 at 1:17 PM Luiz Augusto von Dentz
> <luiz.dentz@xxxxxxxxx> wrote:
> >
> > From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
> >
> > Devices are unlikely to change appearance over time which is the reason
> > why we cache then on the storage so this skips reading it on every
> > reconnection.
> > ---
> > profiles/gap/gas.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/profiles/gap/gas.c b/profiles/gap/gas.c
> > index ea3249be9..400818d67 100644
> > --- a/profiles/gap/gas.c
> > +++ b/profiles/gap/gas.c
> > @@ -142,6 +142,11 @@ static void read_appearance_cb(bool success, uint8_t att_ecode,
> >
> > static void handle_appearance(struct gas *gas, uint16_t value_handle)
> > {
> > + uint16_t value;
> > +
> > + if (!device_get_appearance(gas->device, &value))
> > + return;
> > +
> > if (!bt_gatt_client_read_value(gas->client, value_handle,
> > read_appearance_cb, gas, NULL))
> > DBG("Failed to send request to read appearance");
> > --
> > 2.35.1
>
> Check if the above works for you.
>
Yes, this will work for me.
Reading the appearance still fails, but at least I can manually set it
in the info file, and I can instruct users to do the same,
The other way I was thinking about making it work would be to add some
kind of quirk to skip reading the appearance altogether, which would
probably also require editing a config file anyway, and this way, the
appearance value gets set (im using 0x0192)
Thanks
> --
> Luiz Augusto von Dentz
