Re: [RFC BlueZ] gap: Don't attempt to read the appearance if already set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Luiz,


Am 04.04.22 um 22:17 schrieb Luiz Augusto von Dentz:
From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>

Devices are unlikely to change appearance over time which is the reason
why we cache then on the storage so this skips reading it on every

s/then/them/

reconnection.


Kind regards,

Paul

---
  profiles/gap/gas.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/profiles/gap/gas.c b/profiles/gap/gas.c
index ea3249be9..400818d67 100644
--- a/profiles/gap/gas.c
+++ b/profiles/gap/gas.c
@@ -142,6 +142,11 @@ static void read_appearance_cb(bool success, uint8_t att_ecode,
static void handle_appearance(struct gas *gas, uint16_t value_handle)
  {
+	uint16_t value;
+
+	if (!device_get_appearance(gas->device, &value))
+		return;
+
  	if (!bt_gatt_client_read_value(gas->client, value_handle,
  						read_appearance_cb, gas, NULL))
  		DBG("Failed to send request to read appearance");



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux