Hi Luiz,
> This prints warnings for controllers setting broken quirks to increase
> their visibility and warn about broken controllers firmware that
> probably needs updates to behave properly.
>
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
> ---
> net/bluetooth/hci_sync.c | 44 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
> index 8f4c5698913d..089500136096 100644
> --- a/net/bluetooth/hci_sync.c
> +++ b/net/bluetooth/hci_sync.c
> @@ -3825,6 +3825,48 @@ static int hci_init_sync(struct hci_dev *hdev)
> return 0;
> }
>
> +#define HCI_BROKEN(_quirk, _desc) \
> +{ \
> + .quirk = _quirk, \
> + .desc = _desc, \
> +}
> +
> +struct hci_broken {
> + unsigned long quirk;
> + const char *desc;
> +} hci_broken_table[] = {
> + HCI_BROKEN(HCI_QUIRK_BROKEN_LOCAL_COMMANDS,
> + "HCI Read Local Supported Commands not supported"),
> + HCI_BROKEN(HCI_QUIRK_BROKEN_STORED_LINK_KEY,
> + "HCI Delete Stored Link Key command is advertised, "
> + "but not supported."),
> + HCI_BROKEN(HCI_QUIRK_BROKEN_ERR_DATA_REPORTING,
> + "HCI Read Default Erroneous Data Reporting command is "
> + "advertised, but not supported."),
> + HCI_BROKEN(HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER,
> + "HCI Read Transmit Power Level command is advertised, "
> + "but not supported."),
> + HCI_BROKEN(HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL,
> + "HCI Set Event Filter command not supported."),
> + HCI_BROKEN(HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN,
> + "HCI Enhanced Setup Synchronous Connection command is "
> + "advertised, but not supported.")
> +};
static const hci_quirk_broken
And then HCI_QUIRK_BROKEN(LOCAL_COMMANDS, “text”),
> +
> +static void hci_dev_print_broken(struct hci_dev *hdev)
> +{
> + int i;
> +
> + bt_dev_dbg(hdev, "");
> +
> + for (i = 0; i < ARRAY_SIZE(hci_broken_table); i++) {
> + struct hci_broken *broken = &hci_broken_table[i];
> +
> + if (test_bit(broken->quirk, &hdev->quirks))
> + bt_dev_warn(hdev, "%s", broken->desc);
> + }
> +}
> +
> int hci_dev_open_sync(struct hci_dev *hdev)
> {
> int ret = 0;
> @@ -4031,6 +4073,8 @@ int hci_dev_open_sync(struct hci_dev *hdev)
> }
>
> done:
> + hci_dev_print_broken(hdev);
> +
This is wrong. It gets printed all the time and no matter if success or failure. This needs to go after hdev->setup.
Regards
Marcel
