Re: [PATCH 2/2] Bluetooth: Print broken quirks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

I love your patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on next-20220325]
[cannot apply to bluetooth/master v5.17]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Luiz-Augusto-von-Dentz/Bluetooth-HCI-Add-HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN-quirk/20220326-051551
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: x86_64-randconfig-s021 (https://download.01.org/0day-ci/archive/20220326/202203261536.VslNAaC7-lkp@xxxxxxxxx/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/5ca7f4a3fcd3584b663e15b4c3d8230918b8971d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Luiz-Augusto-von-Dentz/Bluetooth-HCI-Add-HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN-quirk/20220326-051551
        git checkout 5ca7f4a3fcd3584b663e15b4c3d8230918b8971d
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)
>> net/bluetooth/hci_sync.c:3837:3: sparse: sparse: symbol 'hci_broken_table' was not declared. Should it be static?

vim +/hci_broken_table +3837 net/bluetooth/hci_sync.c

  3833	
  3834	struct hci_broken {
  3835		unsigned long quirk;
  3836		const char *desc;
> 3837	} hci_broken_table[] = {
  3838		HCI_BROKEN(HCI_QUIRK_BROKEN_LOCAL_COMMANDS,
  3839			   "HCI Read Local Supported Commands not supported"),
  3840		HCI_BROKEN(HCI_QUIRK_BROKEN_STORED_LINK_KEY,
  3841			   "HCI Delete Stored Link Key command is advertised, "
  3842			   "but not supported."),
  3843		HCI_BROKEN(HCI_QUIRK_BROKEN_ERR_DATA_REPORTING,
  3844			   "HCI Read Default Erroneous Data Reporting command is "
  3845			   "advertised, but not supported."),
  3846		HCI_BROKEN(HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER,
  3847			   "HCI Read Transmit Power Level command is advertised, "
  3848			   "but not supported."),
  3849		HCI_BROKEN(HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL,
  3850			   "HCI Set Event Filter command not supported."),
  3851		HCI_BROKEN(HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN,
  3852			   "HCI Enhanced Setup Synchronous Connection command is "
  3853			   "advertised, but not supported.")
  3854	};
  3855	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux