Hi BlueZ Maintainers, Do we actually want ERROR:INITIALISED_STATIC and ERROR:EXECUTE_PERMISSIONS checkpatch errors? If not, I can help changing the checkpatch config to exclude these. On Fri, Nov 20, 2020 at 1:26 PM <bluez.test.bot@xxxxxxxxx> wrote: > > This is automated email and please do not reply to this email! > > Dear submitter, > > Thank you for submitting the patches to the linux bluetooth mailing list. > This is a CI test results with your patch series: > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=388695 > > ---Test result--- > > ############################## > Test: CheckPatch - FAIL > Output: > battery: Add the internal Battery API > ERROR:INITIALISED_STATIC: do not initialise statics to NULL > #71: FILE: src/battery.c:38: > +static struct queue *batteries = NULL; > > - total: 1 errors, 0 warnings, 215 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > "[PATCH] battery: Add the internal Battery API" has style problems, please review. > > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > test: Add test app for Battery Provider API > ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files > #12: FILE: test/example-battery-provider > > - total: 1 errors, 0 warnings, 230 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > "[PATCH] test: Add test app for Battery Provider API" has style problems, please review. > > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > > ############################## > Test: CheckGitLint - PASS > > ############################## > Test: CheckBuild - PASS > > ############################## > Test: MakeCheck - PASS > > > > --- > Regards, > Linux Bluetooth >
