Hi Johan, On Fri, Oct 23, 2020 at 1:54 AM Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > > Hi Luiz, > > On Thu, Oct 22, 2020, Luiz Augusto von Dentz wrote: > > > On Mon, Oct 19, 2020, Luiz Augusto von Dentz wrote: > > > > This fixes not resetting of the request ID when sending > > > > A2MP_GETAMPASSOC_RSP. > > > > > > > > Fixes: Bluetooth: A2MP: Fix not initializing all members > > > > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> > > > > --- > > > > net/bluetooth/a2mp.c | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > The fix itself looks fine, but I think the "Fixes: ..." line should > > > contain the commit id followed by the commit summary within parentheses, > > > at least based on how I can see this style of annotation used in other > > > commits in the tree. > > > > I did not add a commit id because it did not reached the Linus tree > > yet > > Yes it did: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=eddb7732119d53400f48a02536a84c509692faa8 Somehow I missed that, or git.kernel.org was playing tricks on me, Ive now updated the v3 to include it. > Johan -- Luiz Augusto von Dentz
