Hi Johan, On Thu, Oct 22, 2020 at 2:00 PM Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > > Hi Luiz, > > On Mon, Oct 19, 2020, Luiz Augusto von Dentz wrote: > > This fixes not resetting of the request ID when sending > > A2MP_GETAMPASSOC_RSP. > > > > Fixes: Bluetooth: A2MP: Fix not initializing all members > > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> > > --- > > net/bluetooth/a2mp.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > The fix itself looks fine, but I think the "Fixes: ..." line should > contain the commit id followed by the commit summary within parentheses, > at least based on how I can see this style of annotation used in other > commits in the tree. I did not add a commit id because it did not reached the Linus tree yet and we cannot use the one from bluetooth-next since that tree is rebased then the commit id might change so I thought the only way to do it is by commit message. -- Luiz Augusto von Dentz