Hi Marcel, > -----Original Message----- > From: Marcel Holtmann <marcel@xxxxxxxxxxxx> > Sent: Thursday, July 2, 2020 6:58 PM > To: K, Kiran <kiran.k@xxxxxxxxx> > Cc: linux-bluetooth <linux-bluetooth@xxxxxxxxxxxxxxx>; Srivatsa, Ravishankar > <ravishankar.srivatsa@xxxxxxxxx>; Tumkur Narayan, Chethan > <chethan.tumkur.narayan@xxxxxxxxx>; kiraank@xxxxxxxxx; Bag, Amit K > <amit.k.bag@xxxxxxxxx>; Raghuram Hegde <raghuram.hegde@xxxxxxxxx> > Subject: Re: [PATCH 3/5] Bluetooth: btintel: Refactor firmware payload > download code > > Hi Kiran, > > > Move firmware payload download code to a separate function to enhance > > readability and reusability > > this patch is doing more than that. It also introduces an extra public function. The existing firmware download function is suffixed with "_legacy" to distinguish from an upcoming method to support firmware download in tlv format. I will retain the older one as it is and use "_tlv" suffix for new one without losing the intention of the methods. I will send the changes in the next version. > > Regards > > Marcel Thanks, Kiran