RE: [PATCH 2/5] Bluetooth: btintel: Refactor firmware header download sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

> -----Original Message-----
> From: linux-bluetooth-owner@xxxxxxxxxxxxxxx <linux-bluetooth-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Marcel Holtmann
> Sent: Thursday, July 2, 2020 6:56 PM
> To: K, Kiran <kiran.k@xxxxxxxxx>
> Cc: linux-bluetooth <linux-bluetooth@xxxxxxxxxxxxxxx>; Srivatsa, Ravishankar
> <ravishankar.srivatsa@xxxxxxxxx>; Tumkur Narayan, Chethan
> <chethan.tumkur.narayan@xxxxxxxxx>; kiraank@xxxxxxxxx; Bag, Amit K
> <amit.k.bag@xxxxxxxxx>; Raghuram Hegde <raghuram.hegde@xxxxxxxxx>
> Subject: Re: [PATCH 2/5] Bluetooth: btintel: Refactor firmware header
> download sequence
> 
> Hi Kiran,
> 
> > Move firmware header download code to a separate function to enhance
> > readability and reusability
> >
> > Signed-off-by: Kiran K <kiran.k@xxxxxxxxx>
> > Signed-off-by: Amit K Bag <amit.k.bag@xxxxxxxxx>
> > Signed-off-by: Raghuram Hegde <raghuram.hegde@xxxxxxxxx>
> > Reviewed-by: Chethan T N <chethan.tumkur.narayan@xxxxxxxxx>
> > Reviewed-by: Sathish Narasimman <Sathish.Narasimman@xxxxxxxxx>
> > Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@xxxxxxxxx>
> > ---
> > drivers/bluetooth/btintel.c | 21 +++++++++++++++++----
> > 1 file changed, 17 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> > index dea96c585ecb..1c820c187421 100644
> > --- a/drivers/bluetooth/btintel.c
> > +++ b/drivers/bluetooth/btintel.c
> > @@ -646,12 +646,10 @@ int btintel_read_boot_params(struct hci_dev
> > *hdev, } EXPORT_SYMBOL_GPL(btintel_read_boot_params);
> >
> > -int btintel_download_firmware(struct hci_dev *hdev, const struct firmware
> *fw,
> > -			      u32 *boot_param)
> > +static int btintel_sfi_rsa_header_secure_send(struct hci_dev *hdev,
> > +					      const struct firmware *fw)
> > {
> > 	int err;
> > -	const u8 *fw_ptr;
> > -	u32 frag_len;
> >
> > 	/* Start the firmware download transaction with the Init fragment
> > 	 * represented by the 128 bytes of CSS header.
> > @@ -679,6 +677,21 @@ int btintel_download_firmware(struct hci_dev
> *hdev, const struct firmware *fw,
> > 		bt_dev_err(hdev, "Failed to send firmware signature (%d)",
> err);
> > 		goto done;
> > 	}
> 
> Here should be an extra empty line before the label.

Ack. I will fix it in v2.
> 
> > +done:
> > +	return err;
> > +}
> > +
> > +int btintel_download_firmware(struct hci_dev *hdev, const struct firmware
> *fw,
> > +			      u32 *boot_param)
> > +{
> > +	int err;
> > +	const u8 *fw_ptr;
> > +	u32 frag_len;
> > +
> > +	err = btintel_sfi_rsa_header_secure_send(hdev, fw);
> > +	if (err)
> > +		goto done;
> > +
> 
> Scrap the extra empty line here.

Ack.
> 
> >
> > 	fw_ptr = fw->data + 644;
> > 	frag_len = 0;
> 
> Regards
> 
> Marcel

Thanks,
Kiran





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux