On Tue, Sep 17, 2019 at 02:27:01PM -0700, Abhishek Pandit-Subedi wrote: > If we put a usb device into reset in the suspend callback, it will > disconnect and the resume will not be called. In order to support > turning off the device on suspend and restoring it on resume, we must do > the reset action in suspend_noirq. That's a bit odd given that USB drivers/devices _require_ irqs to be enabled in order to talk to them and work properly. So I don't see how this works at all, nor how any USB driver could even use this. greg k-h