On Tue, Apr 30, 2019 at 02:27:33PM +0800, kbuild test robot wrote: > Hi Matthias, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on bluetooth-next/master] > [also build test ERROR on next-20190429] > [cannot apply to v5.1-rc7] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/Bluetooth-btqca-inject-command-complete-event-during-fw-download/20190430-125407 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master > config: xtensa-allyesconfig (attached as .config) > compiler: xtensa-linux-gcc (GCC) 8.1.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=8.1.0 make.cross ARCH=xtensa > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > drivers/bluetooth/btqca.c: In function 'qca_inject_cmd_complete_event': > >> drivers/bluetooth/btqca.c:286:18: error: 'QCA_HCI_CC_SUCCESS' undeclared (first use in this function); did you mean 'QCA_HCI_CC_OPCODE'? > skb_put_u8(skb, QCA_HCI_CC_SUCCESS); > ^~~~~~~~~~~~~~~~~~ > QCA_HCI_CC_OPCODE > drivers/bluetooth/btqca.c:286:18: note: each undeclared identifier is reported only once for each function it appears in > > vim +286 drivers/bluetooth/btqca.c > > 267 > 268 static int qca_inject_cmd_complete_event(struct hci_dev *hdev) > 269 { > 270 struct hci_event_hdr *hdr; > 271 struct hci_ev_cmd_complete *evt; > 272 struct sk_buff *skb; > 273 > 274 skb = bt_skb_alloc(sizeof(*hdr) + sizeof(*evt) + 1, GFP_KERNEL); > 275 if (!skb) > 276 return -ENOMEM; > 277 > 278 hdr = skb_put(skb, sizeof(*hdr)); > 279 hdr->evt = HCI_EV_CMD_COMPLETE; > 280 hdr->plen = sizeof(*evt) + 1; > 281 > 282 evt = skb_put(skb, sizeof(*evt)); > 283 evt->ncmd = 1; > 284 evt->opcode = HCI_OP_NOP; > 285 > > 286 skb_put_u8(skb, QCA_HCI_CC_SUCCESS); Oh, I changed it in my tree, but somehow missed to include this file in the commit ... I'll fix it in the next version. Since I expect the change to remain controversial I'll wait a bit for other comments before sending out v9. Thanks Matthias
