On Wed, Feb 06, 2019 at 12:43:00PM +0100, Pali Rohár wrote:
> On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
> > Hi,
> >
> > On Wed, Jan 30, 2019 at 02:24:11PM +0200, Luiz Augusto von Dentz wrote:
> > > Hi Pali, Pasi,
> > > On Wed, Jan 30, 2019 at 2:09 PM Pali Rohár <pali.rohar@xxxxxxxxx> wrote:
> > > >
> > > > On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
> > > > > On Wed, Jan 23, 2019 at 06:54:48PM +0100, Pali Rohár wrote:
> > > > > > On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
> > > > > > > Hi Pali,
> > > > > > >
> > > > > > > > ---
> > > > > > > > tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++---
> > > > > > > > 1 file changed, 55 insertions(+), 3 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
> > > > > > > > index 18569c895..a21410f5a 100644
> > > > > > > > --- a/tools/parser/avdtp.c
> > > > > > > > +++ b/tools/parser/avdtp.c
> > > > > > > > @@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
> > > > > > > > {
> > > > > > > > if (vendor == 0x0000004f && vndcodec == 0x0001)
> > > > > > > > return "aptX";
> > > > > > > > + else if (vendor == 0x0000000a && vndcodec == 0x0001)
> > > > > > > > + return "FastStream";
> > > > > > > > + else if (vendor == 0x0000000a && vndcodec == 0x0002)
> > > > > > > > + return "aptX Low Latency";
> > > > > > > > + else if (vendor == 0x000000d7 && vndcodec == 0x0024)
> > > > > > > > + return "aptX HD";
> > > > > > > > else if (vendor == 0x0000012d && vndcodec == 0x00aa)
> > > > > > > > return "LDAC";
> > > > > > > > return "Unknown???;
> > > > > > >
> > > > > > > lets keep the focus on btmon support since nobody should be using hcidump anymore.
> > > > > >
> > > > > > In btmon I already implemented it and patches are now merged. I just
> > > > > > found another place where this capability parsing is implemented and
> > > > > > based on fact that users still use hcidump I quickly looked at it and
> > > > > > implemented this parsing.
> > > > > >
> > > > >
> > > > > I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc),
> > > > > so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
> > > >
> > > > Exactly, people still use hcidump...
> > >
> > > Well it is a deprecated tool which we might remove starting on BlueZ
> > > 6.x which we would like to do in the very next release, if that
> > > doesn't happen than perhaps Id take these patches in for a very last
> > > BlueZ 5.x release.
> > >
> > > @Marcel: Or you have a better plan? We could do one last 5.x and then
> > > start working on removing the deprecated tools/etc.
> > >
> >
> > +1 for doing one last 5.x release before deprecating and removing tools etc!
>
> Ok, what is the plan? If hcidump is not going to be deleted in upcoming
> release, can you take this patch?
>
How about applying this patch now, considering it's small, and has value for anyone using hcidump.
hcidump then gets removed later whenever the removal of deprecated features/tools starts.
Any news about next bluez release?
> --
> Pali Rohár
> pali.rohar@xxxxxxxxx
Thanks,
-- Pasi
