Hi Vasily, Am 18.02.19 um 22:24 schrieb Vasily Khoruzhick: > On Mon, Feb 18, 2019 at 1:10 PM Rob Herring <robh@xxxxxxxxxx> wrote: >> On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote: >>> Add binding document for bluetooth part of RTL8723BS/RTL8723CS >>> >>> Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx> >>> --- >>> .../bindings/net/rtl8723bs-bluetooth.txt | 35 +++++++++++++++++++ >>> 1 file changed, 35 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt >>> >>> diff --git a/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt b/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt >>> new file mode 100644 >>> index 000000000000..8357f242ae4c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt >>> @@ -0,0 +1,35 @@ >>> +RTL8723BS/RTL8723CS Bluetooth >>> +--------------------- >>> + >>> +RTL8723CS/RTL8723CS is WiFi + BT chip. WiFi part is connected over SDIO, while >>> +BT is connected over serial. It speaks H5 protocol with few extra commands >>> +to upload firmware and change module speed. >>> + >>> +Required properties: >>> + >>> + - compatible: should be one of the following: >>> + * "realtek,rtl8723bs-bt" >>> + * "realtek,rtl8723cs-bt" >>> +Optional properties: >>> + >>> + - device-wake-gpios: GPIO specifier, used to wakeup the BT module (active high) >>> + - enable-gpios: GPIO specifier, used to enable the BT module (active high) >>> + - host-wake-gpios: GPIO specifier, used to wakeup the host processor (active high) >>> + - firmware-postfix: firmware postfix to be used for firmware config >> How is this used? > rtl8723bs-bt needs 2 firmware binaries -- one is actual firmware, > another is firmware config which is specific to the board. If > firmware-postfix is specified, driver appends it to the name of config > and requests board-specific config while loading firmware. I.e. if > 'pine64' is specified as firmware-postfix driver will load > rtl8723bs_config-pine64.bin. this is a common problem (e.g. brcmfmac has the same problem [1]). Why not using the "model" property instead of inventing a new software specific property? [1] - https://patchwork.kernel.org/patch/10764463/ > >> Rob >> > _
