Hi Balakrishna, > A small suggestion from my side, suppose in near future ROME <v3.2 wanted to > go with new format i.e. acknowledging for last segment of RAM patch. > then checking rom_build field may not work. > i.e. > if (le16_to_cpu(tlv_patch->rom_build) >= 0x0302) > config->dnld_mode = tlv_patch->download_mode; > > i suggest you to check the byte download_mode directly and decide to wait > for ACK from SoC, for every RAM patch segment sent. > i think byte download_mode is explicitly for mode of downloading the patch > i.e. with ACK or NACK. (pls double confirm about this byte). Yes AFAIK, this byte is for download mode or reserved (0). So yes we can unconditionally check it to determine the mode. Regards, Loic -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
