On Tue, Oct 10, 2017 at 06:16:46PM +1100, Ian W MORRISON wrote: > On 9 October 2017 at 19:06, Johan Hovold <johan@xxxxxxxxxx> wrote: > > On Mon, Oct 09, 2017 at 11:43:31AM +1100, Ian W MORRISON wrote: > <snip> > >> > >> This patch set addresses this by making BT_HCIUART_BCM dependent on > >> SERIAL_DEV_CTRL_TTYPORT which in turn is dependent on SERIAL_DEV_BUS > >> and ensures that if SERIAL_DEV_BUS is selected is the code is build it. > > > > Ok, so you didn't even bother to write two distinct commit messages for > > your two patches, and my comments to the first patch apply also here. > > > <snip> > > > > Johan > > Hi Johan, > > My experience in submitting patches is still limited and I am very > much learning so thanks for the helpful comments and apologies for > trying your patience. My keenness on submitting patches was to show > that I had tested my suggestions so as to given them credibility > rather than any attempt to own the patch. No worries. I can recommend taking a closer look at Documentation/process/submitting-patches.rst where some of the process is described. > What I was trying to do here was to suggested two patches with one > requiring the other. Rather than keep as a single patch affecting two > files I separated into two patches attempting to create a patch series > with a single changelog. This was the wrong approach and I may have > misled so apologies for that. So next, time just submit your patches as a series (consider using git-send-email to get the threading right), where each patch is self-contained and has a good commit message describing why that change is needed. It is implicit that a series is to be applied in order and that therefore later patches in a series can depend on earlier ones. When a patch series span multiple subsystems, things can gets more complicated, though... Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
