Hi Luiz,
Thanks for the update. Is there an estimated time to land this patch?
Best,
Miao
On Sat, Jun 17, 2017 at 12:40 PM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> Hi,
>
> On Thu, Jun 15, 2017 at 5:31 AM, Miao-chen Chou <mcchou@xxxxxxxxxxxx> wrote:
>> Hi Luiz,
>>
>> Thanks for the patch. It'd be better if a bit more description is
>> added to main.conf about the difference between "always" and "yes"
>> options in terms of unpair/paired devices. The fix looks good to me.
>
> Ive added some description for the options.
>
>> Thanks,
>> Miao
>>
>> On Tue, Jun 13, 2017 at 10:44 AM, Vinicius Costa Gomes
>> <vinicius.gomes@xxxxxxxxx> wrote:
>>> Hi Luiz,
>>>
>>> Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> writes:
>>>> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>>>>
>>>> This adds GATT.Cache config option to main.conf which can be used
>>>> to adjust the cache expected behavior of attributes found over GATT.
>>>> ---
>>>> src/device.c | 28 ++++++++++++++++++++++++++++
>>>> src/hcid.h | 7 +++++++
>>>> src/main.c | 26 +++++++++++++++++++++++++-
>>>> src/main.conf | 6 ++++++
>>>> 4 files changed, 66 insertions(+), 1 deletion(-)
>>>>
>>>
>>> [...]
>>>
>>>>
>>>> +static void parse_gatt_cache(const char *cache)
>>>> +{
>>>> + if (!strcmp(cache, "always")) {
>>>> + main_opts.gatt_cache = BT_GATT_CACHE_ALWAYS;
>>>> + } else if (!strcmp(cache, "yes")) {
>>>> + main_opts.gatt_cache = BT_GATT_CACHE_YES;
>>>> + } else if (!strcmp(cache, "no")) {
>>>> + main_opts.gatt_cache = BT_GATT_CACHE_NO;
>>>> + } else {
>>>> + DBG("Invalid value for KeepCache=%s", cache);
>>>> + }
>>>
>>> [optional] I wonder if making this return the enum, and return the
>>> default if 'cache' is NULL, would make the code clearer.
>
> Done.
>
>>>> +}
>>>> +
>>>> static void check_config(GKeyFile *config)
>>>> {
>>>> - const char *valid_groups[] = { "General", "Policy", NULL };
>>>> + const char *valid_groups[] = { "General", "Policy", "GATT", NULL };
>>>> char **keys;
>>>> int i;
>>>>
>>>> @@ -357,6 +370,17 @@ static void parse_config(GKeyFile *config)
>>>> g_clear_error(&err);
>>>> else
>>>> main_opts.fast_conn = boolean;
>>>> +
>>>> + str = g_key_file_get_string(config, "GATT", "Cache", &err);
>>>> + if (err) {
>>>> + g_clear_error(&err);
>>>> + main_opts.gatt_cache = BT_GATT_CACHE_ALWAYS;
>>>> + return;
>>>> + }
>>>> +
>>>> + parse_gatt_cache(str);
>>>> +
>>>> + g_free(str);
>>>> }
>>>>
>>>> static void init_defaults(void)
>>>> diff --git a/src/main.conf b/src/main.conf
>>>> index a649276..7807a8f 100644
>>>> --- a/src/main.conf
>>>> +++ b/src/main.conf
>>>> @@ -71,6 +71,12 @@
>>>> # Defaults to "off"
>>>> # Privacy = off
>>>>
>>>> +[GATT]
>>>> +# GATT attribute cache.
>>>> +# Possible values: always, yes, no
>>>> +# Default: always
>>>> +#Cache = always
>>>> +
>>>> [Policy]
>>>> #
>>>> # The ReconnectUUIDs defines the set of remote services that should try
>>>> --
>
> Applied after a few changes mentioned above.
>
> --
> Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
