Hi Marcel, On Wed, Apr 26, 2017 at 5:49 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Luiz, > >> In case of receiving an unknown command no response shall be generated. >> --- >> src/shared/att.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/shared/att.c b/src/shared/att.c >> index 3071b51..10e182f 100644 >> --- a/src/shared/att.c >> +++ b/src/shared/att.c >> @@ -148,7 +148,7 @@ static enum att_op_type get_op_type(uint8_t opcode) >> return att_opcode_type_table[i].type; >> } >> >> - return ATT_OP_TYPE_UNKNOWN; >> + return opcode & ATT_OP_CMD_MASK ? ATT_OP_TYPE_CMD : ATT_OP_TYPE_UNKNOWN; >> } > > for readability I would use this: > > return (opcode & ATT_OP_CMD_MASK) ? ATT_OP_TYPE_CMD : ATT_OP_TYPE_UNKNOWN; > > Or just do this: > > if (opcode & ATT_OP_CMD_MASK) > return ATT_OP_TYPE_CMD; > > return ATT_OP_TYPE_UNKNOWN; Ive made these modifications above and applied the patch. > Regards > > Marcel > -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
