Hi Szymon,
>> Bluetooth would crash when computing ECDH keys with kpp
>> if VMAP_STACK is enabled. Fix by allocating data passed
>> to kpp on heap.
>>
>> Fixes: 58771c1c ("Bluetooth: convert smp and selftest to crypto kpp
>> API")
>> Signed-off-by: Salvatore Benedetto <salvatore.benedetto@xxxxxxxxx>
>> ---
>> net/bluetooth/ecdh_helper.c | 6 ++++--
>> net/bluetooth/selftest.c | 16 +++++++++++-----
>> 2 files changed, 15 insertions(+), 7 deletions(-)
>>
>> diff --git a/net/bluetooth/ecdh_helper.c b/net/bluetooth/ecdh_helper.c
>> index b6d9aa1..8018447 100644
>> --- a/net/bluetooth/ecdh_helper.c
>> +++ b/net/bluetooth/ecdh_helper.c
>> @@ -59,7 +59,7 @@ bool compute_ecdh_secret(const u8 public_key[64], const u8
>> private_key[32], struct ecdh p;
>> struct ecdh_completion result;
>> struct scatterlist src, dst;
>> - u8 tmp[64];
>> + u8 *tmp = kmalloc(64, GFP_KERNEL);
>
> Should this be checked for null?
possible yes, how do other crypto users did this when they converted to VMAP_STACK support. We should do exactly the same as others did.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
