Hi,
On Sat, Nov 19, 2016 at 3:32 AM, <mcchou@xxxxxxxxxxxx> wrote:
> From: Miao-chen Chou <mcchou@xxxxxxxxxxxx>
>
> Packed structs have a default alignment of 1. If address of a member
> is taken, the pointer value could be unaligned. Unaligned memory accesses
> can result in a crash in some architectures.
Afaik if it is byte aligned it shall never cause unaligned memory
accesses as the members are loaded byte a byte. which is what we want
here since it is a network PDU we don't want padding.
> ---
> monitor/rfcomm.c | 2 +-
> monitor/rfcomm.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/monitor/rfcomm.c b/monitor/rfcomm.c
> index b32ad40..7c688af 100644
> --- a/monitor/rfcomm.c
> +++ b/monitor/rfcomm.c
> @@ -106,7 +106,7 @@ struct rfcomm_rpn {
> uint8_t xon;
> uint8_t xoff;
> uint16_t pm;
> -} __attribute__ ((packed));
> +} __attribute__ ((packed, aligned(2)));
>
> struct rfcomm_rls {
> uint8_t dlci;
> diff --git a/monitor/rfcomm.h b/monitor/rfcomm.h
> index c157352..a8af484 100644
> --- a/monitor/rfcomm.h
> +++ b/monitor/rfcomm.h
> @@ -77,4 +77,4 @@ struct rfcomm_pn {
> uint16_t mtu;
> uint8_t max_retrans;
> uint8_t credits;
> -} __attribute__((packed));
> +} __attribute__((packed, aligned(2)));
> --
> 2.8.0.rc3.226.g39d4020
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
