Re: [PATCH BlueZ] core/advertising: Fix not adding local name and appearance flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Jul 22, 2016 at 4:56 PM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> If the advertisement is cause the connectable flag to be set add local
> name and appearance so the scan response is generated properly as the
> remote may attempt connect/pair these information shall be made available
> as well.
> ---
>  src/advertising.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/advertising.c b/src/advertising.c
> index d2019de..52b536d 100644
> --- a/src/advertising.c
> +++ b/src/advertising.c
> @@ -473,7 +473,8 @@ static DBusMessage *refresh_advertisement(struct advertisement *ad)
>         DBG("Refreshing advertisement: %s", ad->path);
>
>         if (ad->type == AD_TYPE_PERIPHERAL)
> -               flags = MGMT_ADV_FLAG_CONNECTABLE | MGMT_ADV_FLAG_DISCOV;
> +               flags = MGMT_ADV_FLAG_CONNECTABLE | MGMT_ADV_FLAG_DISCOV |
> +                       MGMT_ADV_FLAG_APPEARANCE | MGMT_ADV_FLAG_LOCAL_NAME;
>
>         if (ad->include_tx_power)
>                 flags |= MGMT_ADV_FLAG_TX_POWER;
> --
> 2.7.4

This does not work since the kernel does not even check those flags,
instead it seems to expect the scan data to come directly from
userspace.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux