Re: [PATCH v2] drivers/net/ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 08/12/15 15:56, Michael Hennerich wrote:
On 12/08/2015 03:05 PM, Stefan Schmidt wrote:


On 08/12/15 14:37, Stefan Schmidt wrote:
Hello.

On 08/12/15 12:52, michael.hennerich@xxxxxxxxxx wrote:


+++ b/drivers/net/ieee802154/adf7242.c
@@ -0,0 +1,1251 @@
+/*
+ * Analog Devices ADF7242 Low-Power IEEE 802.15.4 Transceiver
+ *
+ * Copyright 2009-2015 Analog Devices Inc.
+ *
+ * Licensed under the GPL-2 or later.
+ *
+ * http://www.analog.com/ADF7242
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/interrupt.h>
+#include <linux/delay.h>
+#include <linux/mutex.h>
+#include <linux/workqueue.h>
+#include <linux/spinlock.h>
+#include <linux/firmware.h>
+#include <linux/spi/spi.h>
+#include <linux/skbuff.h>
+#include <linux/of.h>
+#include <linux/irq.h>
+#include <linux/delay.h>
+#include <linux/debugfs.h>
+#include <linux/ieee802154.h>
+#include <net/mac802154.h>
+#include <net/cfg802154.h>
+
+#define FIRMWARE "adf7242_firmware.bin"
+#define MAX_POLL_LOOPS 200

You increased the MAX_POLL_LOOPS to 200 from 50 here since the last
version. Any reason for it?

Hi Stefan,

Two reasons.
I added a wait for RC_STATUS_PHY_RDY at the top of the threaded ISR handler. Depending on the state it may now poll a little bit longer. Typical loop counts I've seen were around 20-30. The platform I'm currently testing with requires a FPGA bitsream rebuild to change the SPI clock rate. In case SPI clock moved to the fast end 50 loops might not be sufficient anymore.
I then added 100% on top of it to be on the safe side.


Interesting platform :)

As the loop count normally goes only to 30 this number does indeed not really matter. I was just curious because I saw the change but noting mentioned in the log for the new version. So I thought I might ask :)

regards
Stefan Schmidt

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux