Re: [PATCH] tools/hciattach: Add support for BCM line discipline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi John,

>>> This is similar to the "bcm43xx" option but using the kernel driver
>>> has the advantage that the wakeup and shutdown pins on the device
>>> can be used.  
>> 
>> what is wrong with just using btattach?
> 
> It's marked as experimental and not installed by "make install", so I
> assumed that it was only supposed to be used for testing.

hmm, not installed by default. I do not remember the reason for that, but I am sure I had one. However btattach is so dead simple that it should be used. Seems like we should look into making sure the command line options are stable and we install it by default.

The hciattach code is the most horrific code we have in our tree. I really dislike it and there is almost zero chance to clean it up. I am not sure that I want to pile on top of it.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux