Hi Luiz,
On Tue, Nov 17, 2015 at 9:33 AM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> Hi Andrzej,
>
> On Sat, Nov 14, 2015 at 3:44 PM, Andrzej Kaczmarek
> <andrzej.kaczmarek@xxxxxxxxxxx> wrote:
>> Hi,
>>
>> Here's series of patches which adds decoding of AVDTP signalling channel
>> and A2DP codec capabilities information. Few things are missing:
>> - no fragmentation support
>> - some rarely used capabilities are not decoded
>> - ATRAC capabilities are not decoded
>>
>> Other that above, pretty much everything should be decoded.
>>
>> And some sample output from decoder:
>>
>> < ACL Data TX: Handle 256 flags 0x00 dlen 6
>> Channel: 1602 len 2 [PSM 25 mode 0] {chan 2}
>> AVDTP: Discover (0x01) Command: type 0x00 label 6 nosp 0
>>> ACL Data RX: Handle 256 flags 0x02 dlen 14
>> Channel: 66 len 10 [PSM 25 mode 0] {chan 2}
>> AVDTP: Discover (0x01) Response Accept: type 0x00 label 6 nosp 0
>> ACP SEID 1
>> Media Type: Audio
>> SEP Type: SRC
>> In use: No
>> ACP SEID 5
>> Media Type: Audio
>> SEP Type: SRC
>> In use: No
>> ACP SEID 3
>> Media Type: Audio
>> SEP Type: SRC
>> In use: No
>> ACP SEID 2
>> Media Type: Audio
>> SEP Type: SRC
>> In use: No
>
> I guess we can add it In use flag only when set.
>
>>
>>
>> < ACL Data TX: Handle 256 flags 0x00 dlen 7
>> Channel: 1602 len 3 [PSM 25 mode 0] {chan 2}
>> AVDTP: Get Capabilities (0x02) Command: type 0x00 label 9 nosp 0
>> ACP SEID: 3
>>> ACL Data RX: Handle 256 flags 0x02 dlen 23
>> Channel: 66 len 19 [PSM 25 mode 0] {chan 2}
>> AVDTP: Get Capabilities (0x02) Response Accept: type 0x00 label 9 nosp 0
>> Service Category: Media Transport
>> Service Category: Media Codec
>> Media Type: Audio
>> Media Codec: Non-A2DP
>> Vendor ID: 0x0000004f (APT Licensing Ltd.)
>> Vendor Specific Codec ID: 0x0001 (aptX)
>> Frequency: 0x30
>> 44100
>> 48000
>> Channel Mode: 0x02
>> Stereo
>> Service Category: Content Protection
>> Content Protection Type: SCMS-T
>>
>>
>> < ACL Data TX: Handle 256 flags 0x00 dlen 18
>> Channel: 1602 len 14 [PSM 25 mode 0] {chan 2}
>> AVDTP: Set Configuration (0x03) Command: type 0x00 label 11 nosp 0
>> ACP SEID: 1
>> INT SEID: 1
>> Service Category: Media Transport
>> Service Category: Media Codec
>> Media Type: Audio
>> Media Codec: SBC
>> Frequency: 0x20
>> 44100
>> Channel Mode: 0x01
>> Joint Channel
>> Block Length: 0x10
>> 16
>> Subbands: 0x04
>> 8
>> Allocation Method: 0x01
>> Loudness
>> Minimum Bitpool: 2
>> Maximum Bitpool: 53
>
> Id got with a range instead of 2 field e.g. Bitpool: 2-53. Actually
> overall Id make this more compact instead of having another line for
> the decoded value just input in the same line with the hex value in
> parenthesis.
>
>>> ACL Data RX: Handle 256 flags 0x02 dlen 6
>> Channel: 66 len 2 [PSM 25 mode 0] {chan 2}
>> AVDTP: Set Configuration (0x03) Response Accept: type 0x00 label 11 nosp 0
>>
>>> ACL Data RX: Handle 256 flags 0x02 dlen 6
>> Channel: 66 len 2 [PSM 25 mode 0] {chan 2}
>> AVDTP: Open (0x06) Response Accept: type 0x00 label 12 nosp 0
>>
>>
>> < ACL Data TX: Handle 256 flags 0x00 dlen 7
>> Channel: 1602 len 3 [PSM 25 mode 0] {chan 2}
>> AVDTP: Start (0x07) Command: type 0x00 label 13 nosp 0
>> ACP SEID: 1
>>> ACL Data RX: Handle 256 flags 0x02 dlen 6
>> Channel: 66 len 2 [PSM 25 mode 0] {chan 2}
>> AVDTP: Start (0x07) Response Accept: type 0x00 label 13 nosp 0
>
> Would you be able to include the output above into the patch that
> introduce it? I think it is a bit better to see the formatting each
> patch is introducing and then have proper comments to them.
Sure, I'll do this in v2.
For the other comments I'll go with Marcel''s suggestions.
BR,
Andrzej
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
