Hi Marcel,
On Tue, Nov 03, 2015, Marcel Holtmann wrote:
> Hi Johan,
>
> >> There are some BR/EDR default events for Bluetooth 1.2 or later
> >> controllers that are not conditional on their features being present.
> >>
> >> Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> >> ---
> >> net/bluetooth/hci_core.c | 12 ++++++++----
> >> 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > I realize I already applied this one, but:
> >
> >> + if (lmp_esco_capable(hdev)) {
> >> + events[5] |= 0x08; /* Synchronous Connection Complete */
> >> + events[5] |= 0x10; /* Synchronous Connection Changed */
> >> + }
> >
> > Synchronous Connection Complete is relevant also for non-ESCO
> > controllers, isn't it?
>
> that is true, but if you look at hci_conn.c and sco.c, then you see we
> use the same logic there to decide if we use Add SCO or Setup Sync
> Connection. So this just brings that in sync.
Understood, it took some time for me to figure out from the core spec
exactly under which conditions Conn Complete or Sync Conn Complete will
happen.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
