Hi Johan,
>> For the LE only controllers, there are events that should not be enabled
>> if the corresponding command is not supported.
>>
>> Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
>> ---
>> net/bluetooth/hci_core.c | 15 +++++++++++----
>> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> I've applied patches 1, 2 and 4 from this set, but could you add some
> clarifications to this one:
>
>> @@ -534,13 +534,20 @@ static void hci_setup_event_mask(struct hci_request *req)
>> } else {
>> /* Use a different default for LE-only devices */
>> memset(events, 0, sizeof(events));
>> - events[0] |= 0x10; /* Disconnection Complete */
>> - events[1] |= 0x08; /* Read Remote Version Information Complete */
>> events[1] |= 0x20; /* Command Complete */
>> events[1] |= 0x40; /* Command Status */
>> events[1] |= 0x80; /* Hardware Error */
>> - events[2] |= 0x04; /* Number of Completed Packets */
>> - events[3] |= 0x02; /* Data Buffer Overflow */
>> +
>> + if (hdev->commands[0] & 0x20) {
>> + events[0] |= 0x10; /* Disconnection Complete */
>> + events[2] |= 0x04; /* Number of Completed Packets */
>> + events[3] |= 0x02; /* Data Buffer Overflow */
>> + }
>
> Which exact command is "hdev->commands[0] & 0x20"? Could you add a code
> comment here to make it clear.
it is the Disconnect command. I add the data related flow control ones since if you do not have support for Disconnect command, you also have no support for LE Create Connection and that means no data connection support. However comments sounds like a good idea.
>> + if (hdev->commands[2] & 0x80)
>> + events[1] |= 0x08; /* Read Remote Version Information
>> + * Complete
>> + */
>
> I assume this one is HCI_Read_Remote_Version_Information, but might be
> good to add a code comment for it too.
Sure thing.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
