Hi Amitkumar,
>>> These changes resolve below checkpatch warning
>>>
>>> WARNING: Possible unnecessary 'out of memory' message
>>>
>>> Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
>>> ---
>>> drivers/bluetooth/btmrvl_main.c | 8 ++------
>>> drivers/bluetooth/btmrvl_sdio.c | 5 ++---
>>> 2 files changed, 4 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/bluetooth/btmrvl_main.c
>>> b/drivers/bluetooth/btmrvl_main.c index 6ba2286..61d2f39 100644
>>> --- a/drivers/bluetooth/btmrvl_main.c
>>> +++ b/drivers/bluetooth/btmrvl_main.c
>>> @@ -712,16 +712,12 @@ struct btmrvl_private *btmrvl_add_card(void
>> *card)
>>> struct btmrvl_private *priv;
>>>
>>> priv = kzalloc(sizeof(*priv), GFP_KERNEL);
>>> - if (!priv) {
>>> - BT_ERR("Can not allocate priv");
>>> + if (!priv)
>>> goto err_priv;
>>> - }
>>
>> I do not get these checkpatch fixes. Why is the error messages unneeded?
>>
>
> Linux kernel already displays a generic message and stack dump in this case. So this error message would be redundant.
> More details on checkpatch code change: http://lkml.iu.edu/hypermail/linux/kernel/1406.1/01508.html
fair enough. I can accept this premise.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
