These changes resolve below checkpatch warning WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> --- drivers/bluetooth/btmrvl_main.c | 8 ++------ drivers/bluetooth/btmrvl_sdio.c | 5 ++--- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/bluetooth/btmrvl_main.c b/drivers/bluetooth/btmrvl_main.c index 6ba2286..61d2f39 100644 --- a/drivers/bluetooth/btmrvl_main.c +++ b/drivers/bluetooth/btmrvl_main.c @@ -712,16 +712,12 @@ struct btmrvl_private *btmrvl_add_card(void *card) struct btmrvl_private *priv; priv = kzalloc(sizeof(*priv), GFP_KERNEL); - if (!priv) { - BT_ERR("Can not allocate priv"); + if (!priv) goto err_priv; - } priv->adapter = kzalloc(sizeof(*priv->adapter), GFP_KERNEL); - if (!priv->adapter) { - BT_ERR("Allocate buffer for btmrvl_adapter failed!"); + if (!priv->adapter) goto err_adapter; - } btmrvl_init_adapter(priv); diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c index 71ea2a3..e039fc9 100644 --- a/drivers/bluetooth/btmrvl_sdio.c +++ b/drivers/bluetooth/btmrvl_sdio.c @@ -1382,10 +1382,9 @@ done: return; fw_dump_data = vzalloc(fw_dump_len+1); - if (!fw_dump_data) { - BT_ERR("Vzalloc fw_dump_data fail!"); + if (!fw_dump_data) return; - } + fw_dump_ptr = fw_dump_data; /* Dump all the memory data into single file, a userspace script will -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html