On Tue, Jul 14 2015, Luiz Augusto von Dentz wrote: Hi Luiz, >> + /* Fix devices that report HEADSET_HS_UUID before HSP_HS_UUID, >> + * contrary to what Erratum #3507 says. >> + */ >> + if ((bt_uuid_strcmp(profile_uuid, HEADSET_HS_UUID) == 0)) { > > I guess we could stop right here and just assume it should be > HSP_HS_UUID instead so you just have to free and use assign > g_strdup(HSP_HS_UUID) to profile_uuid. That was exactly what I did in my first (private) version of the patch. But I wanted to play safe and make sure HSP_HS_UUID was also there. Frankly, I don't know how broken other devices are, as I don't deal with Bluetooth on a regular basis. So I fully trust your judgement on this :-) Best regards, -- Iñaki Arenaza Electronics and Computing Department Mondragon University – Faculty of Engineering http://www.mondragon.edu/ Goiru kalea 2, 20500 Arrasate-Mondragon (Spain) Tel: +34 647503750 (direct) / +34 943794700 (pbx) -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html