Hi Marcel, >-----Original Message----- >From: linux-bluetooth-owner@xxxxxxxxxxxxxxx >[mailto:linux-bluetooth-owner@xxxxxxxxxxxxxxx] On Behalf Of Marcel Holtmann >Sent: Tuesday, May 26, 2015 3:06 AM >To: Wang, Arron >Cc: linux-bluetooth@xxxxxxxxxxxxxxx >Subject: Re: [PATCH 2/2] Bluetooth: Add option to enable/disable A2MP module > >Hi Arron, > >> Make Bluetooth 3.0 HS feature configurable >> >> Signed-off-by: Arron Wang <arron.wang@xxxxxxxxx> >> --- >> net/bluetooth/Kconfig | 5 + >> net/bluetooth/Makefile | 3 +- >> net/bluetooth/a2mp.h | 19 +++ >> net/bluetooth/amp.h | 11 ++ >> net/bluetooth/hci_event.c | 260 +----------------------------------- >> net/bluetooth/hci_event_a2mp.c | 283 >++++++++++++++++++++++++++++++++++++++++ >> net/bluetooth/hci_event_a2mp.h | 91 +++++++++++++ >> 7 files changed, 412 insertions(+), 260 deletions(-) create mode >> 100644 net/bluetooth/hci_event_a2mp.c create mode 100644 >> net/bluetooth/hci_event_a2mp.h > >I don’t think this is the solution here. I think A2MP support should be self >contained and utilises the synchronous HCI command framework we have in place >and also use in mgmt. Yes, create a separate file for hci a2mp event maybe not suitable, but there are many hci ops/events for different Bluetooth controller BREDR/AMP/LE, add the macro to separate them in one file may not easy to maintain, can we move these AMP releated hci ops/event function to file amp.c? >> diff --git a/net/bluetooth/Kconfig b/net/bluetooth/Kconfig index >> e7bca37..a558c66 100644 >> --- a/net/bluetooth/Kconfig >> +++ b/net/bluetooth/Kconfig >> @@ -27,6 +27,7 @@ menuconfig BT >> SMP (Security Manager Protocol) on LE (Low Energy) links >> HCI Device drivers (Interface to the hardware) >> SCO Module (SCO audio links) >> + A2MP Module (AMP Manager Protocol) >> RFCOMM Module (RFCOMM Protocol) >> BNEP Module (Bluetooth Network Encapsulation Protocol) >> CMTP Module (CAPI Message Transport Protocol) @@ -53,6 +54,10 @@ >> config BT_SCO >> SCO link provides voice transport over Bluetooth. SCO support is >> required for voice applications like Headset and Audio. >> >> +config BT_A2MP >> + bool "Bluetooth Alternate MAC/PHY (AMP) features" >> + depends on BT_BREDR >> + > >The option name you are looking for for BT_HS for high speed support. A2MP and >AMP support should be hidden behind that config option. Yes, I'll change them to BT_HS. Thanks Arron
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
