Re: [PATCH 2/2] Bluetooth: Add option to enable/disable A2MP module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arron,

> Make Bluetooth 3.0 HS feature configurable
> 
> Signed-off-by: Arron Wang <arron.wang@xxxxxxxxx>
> ---
> net/bluetooth/Kconfig          |    5 +
> net/bluetooth/Makefile         |    3 +-
> net/bluetooth/a2mp.h           |   19 +++
> net/bluetooth/amp.h            |   11 ++
> net/bluetooth/hci_event.c      |  260 +-----------------------------------
> net/bluetooth/hci_event_a2mp.c |  283 ++++++++++++++++++++++++++++++++++++++++
> net/bluetooth/hci_event_a2mp.h |   91 +++++++++++++
> 7 files changed, 412 insertions(+), 260 deletions(-)
> create mode 100644 net/bluetooth/hci_event_a2mp.c
> create mode 100644 net/bluetooth/hci_event_a2mp.h

I don’t think this is the solution here. I think A2MP support should be self contained and utilises the synchronous HCI command framework we have in place and also use in mgmt.

> diff --git a/net/bluetooth/Kconfig b/net/bluetooth/Kconfig
> index e7bca37..a558c66 100644
> --- a/net/bluetooth/Kconfig
> +++ b/net/bluetooth/Kconfig
> @@ -27,6 +27,7 @@ menuconfig BT
> 		SMP (Security Manager Protocol) on LE (Low Energy) links
> 	     HCI Device drivers (Interface to the hardware)
> 	     SCO Module (SCO audio links)
> +	     A2MP Module (AMP Manager Protocol)
> 	     RFCOMM Module (RFCOMM Protocol)  
> 	     BNEP Module (Bluetooth Network Encapsulation Protocol)
> 	     CMTP Module (CAPI Message Transport Protocol)
> @@ -53,6 +54,10 @@ config BT_SCO
> 	  SCO link provides voice transport over Bluetooth.  SCO support is
> 	  required for voice applications like Headset and Audio.
> 
> +config BT_A2MP
> +	bool "Bluetooth Alternate MAC/PHY (AMP) features"
> +	depends on BT_BREDR
> +

The option name you are looking for for BT_HS for high speed support. A2MP and AMP support should be hidden behind that config option.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux