Hi Marcel: On Mon, Apr 13, 2015 at 11:16 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Michael, > >>>> Adds a method to add the TX Power attribute to the advertisements that are sent >>>> through the D-Bus interface, and supports more than one advertisement based on >>>> the maximum number reported by the kernel. >>> >>> That doesn't say why we should expose the IncludeTXPower, I thought we >>> would let bluetoothd figure if that should be included or not, we may >>> not have enough space or don't have this information from the >>> controller. >>> >> >> This just exposes the flag that is available on the MGMT API. If we >> don't have a reason to turn it on and off from user space, we should >> remove that flag too. > > the kernel side needs this flag. You can not emulate it from userspace. The reason is that userspace has no idea what the actual TX power is. Only the kernel knows. If you build the value in userspace by yourself, then you are plain faking / hardcoding it. We are not emulating it from userspace. This property signals to the kernel to include the power. It mirrors the MGMT API flag on the Add Advertising Command: 4 Add TX Power field to Adv_Data We do not build the value in userspace, but just set this flag when the property is set. > > Regards > > Marcel > -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
