Hi Luiz, On Mon, Apr 13, 2015 at 6:38 AM, Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote: > Hi Michael, > > On Fri, Apr 10, 2015 at 10:06 PM, Michael Janssen <jamuraa@xxxxxxxxxxxx> wrote: >> Adds a method to add the TX Power attribute to the advertisements that are sent >> through the D-Bus interface, and supports more than one advertisement based on >> the maximum number reported by the kernel. > > That doesn't say why we should expose the IncludeTXPower, I thought we > would let bluetoothd figure if that should be included or not, we may > not have enough space or don't have this information from the > controller. > This just exposes the flag that is available on the MGMT API. If we don't have a reason to turn it on and off from user space, we should remove that flag too. I would rather get an error when I want to include TX Power and there isn't enough space to include it instead of having to discover by testing that it is not there when I want to use it. >> Michael Janssen (4): >> doc: Add IncludeTXPower to LE Advertising API >> core/advertising: Parse IncludeTXPower >> core/advertising: Support more than one advertisement. >> test: add IncludeTXPower to example-advertisement >> >> doc/advertising-api.txt | 5 +++ >> src/advertising.c | 86 +++++++++++++++++++++++++++++++++++++++++----- >> test/example-advertisement | 4 +++ >> 3 files changed, 87 insertions(+), 8 deletions(-) >> >> -- >> 2.2.0.rc0.207.ga3a616c >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > Luiz Augusto von Dentz -- M Janssen -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
