Hi Arman, On Thu, Feb 26, 2015 at 10:32 PM, Arman Uguray <armansito@xxxxxxxxxxxx> wrote: > Hi Marcel, > >> On Thu, Feb 26, 2015 at 7:38 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: >> Hi Arman, >> >>> GDBusClient currently hard-codes "/" as the remote ObjectManager path. >>> This is generally incorrect, as an application can choose to expose an >>> ObjectManager at any well-known path. This patch fixes this by allowing >>> the user to pass in the ObjectManager path to g_dbus_client_new. >>> --- >>> client/main.c | 2 +- >>> gdbus/client.c | 23 ++++++++++++++++------- >>> gdbus/gdbus.h | 5 +++-- >>> plugins/hostname.c | 2 +- >>> profiles/iap/main.c | 2 +- >>> tools/bluetooth-player.c | 2 +- >>> tools/gap-tester.c | 3 ++- >>> tools/gatt-service.c | 2 +- >>> tools/mpris-proxy.c | 2 +- >>> tools/obexctl.c | 2 +- >>> unit/test-gdbus-client.c | 39 ++++++++++++++++++++++++++------------- >>> 11 files changed, 54 insertions(+), 30 deletions(-) >> >> please to not intermix gdbus/ changes with others. Everything in gdbus/ needs to be a separate patch. You are affecting more than one project here. >> > > This is a gdbus/ only change but I it changes an API definition so all > of these other spots need to be updated otherwise the code won't > compile. I wonder if we really need this change or we should have a different function. e.g. g_dbus_client_new_full where we can include the object manager path without breaking backward compatibility. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
