Re: [PATCH BlueZ v1 03/17] gdbus/client: Allow specifying ObjectManager path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

> On Thu, Feb 26, 2015 at 7:38 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Arman,
>
>> GDBusClient currently hard-codes "/" as the remote ObjectManager path.
>> This is generally incorrect, as an application can choose to expose an
>> ObjectManager at any well-known path. This patch fixes this by allowing
>> the user to pass in the ObjectManager path to g_dbus_client_new.
>> ---
>> client/main.c            |  2 +-
>> gdbus/client.c           | 23 ++++++++++++++++-------
>> gdbus/gdbus.h            |  5 +++--
>> plugins/hostname.c       |  2 +-
>> profiles/iap/main.c      |  2 +-
>> tools/bluetooth-player.c |  2 +-
>> tools/gap-tester.c       |  3 ++-
>> tools/gatt-service.c     |  2 +-
>> tools/mpris-proxy.c      |  2 +-
>> tools/obexctl.c          |  2 +-
>> unit/test-gdbus-client.c | 39 ++++++++++++++++++++++++++-------------
>> 11 files changed, 54 insertions(+), 30 deletions(-)
>
> please to not intermix gdbus/ changes with others. Everything in gdbus/ needs to be a separate patch. You are affecting more than one project here.
>

This is a gdbus/ only change but I it changes an API definition so all
of these other spots need to be updated otherwise the code won't
compile.

> Regards
>
> Marcel
>

Arman
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux