Hi!
> > I have created provisional device tree binding, and the driver still
> > works.
>
> I don't have time to look at the code now, but I have some comments
> regarding the binding.
> >
> > &uart2 {
> > + compatible = "brcm,uart,bcm2048";
>
> This does not look correct. The uart should not be overwritten. The
> current h4p driver indeed implements a driver for the serial port,
> but that's a) linux specific and does not belong in the DT and b)
> should probably be changed in the mainline kernel.
Yes, bettter solution is needed here. But see the code, I don't see
how b) would be implemented.
> > interrupts-extended = <&intc 73 &omap3_pmx_core OMAP3_UART2_RX>;
> > pinctrl-names = "default";
> > pinctrl-0 = <&uart2_pins>;
> > + device {
> > + compatible = "brcm,bcm2048";
> > + uart = <&uart2>;
>
> You don't need a phandle to the parent device.
Ok.
> > + reset-gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>; /* want 91 */
> > + host-wakeup-gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; /* want 101 */
>
> The host-wakeup should be mapped as irq, gpio2irq conversion
> will happen ;)
Why? It is accessed as gpio, too.
> > + chip-type = <3>;
>
> This should be set in the driver based on the compatible
> value and not via DT data.
Ok
> > + clocks = <&uart2_fck>, <&uart2_ick>;
> > + clock-names = "fck", "ick";
>
> These clocks you defined belong to the uart device and not to the
> uart slave (bluetooth) device.
Ok. Why are they only needed in the bluetooth case?
> > + bt-sysclk = <2>;
>
> I think this should be mapped cleanly in DT by adding a new clock
> to the DTS file:
>
> vctcxo_clock: clock {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> clock-frequency = <38400000>;
> };
No. It seems that this selects baud rate during the chip init. I guess
I can just remove that one.
> Then the bluetooth device can reference its clock device:
>
> clocks = <&vctcxo_clock>;
>
> The same clock reference should be added to the wl1251 DT node :)
Feel free to do that, but I don't see how this one helps...?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
