Hi Arman, On Tue, Dec 09, 2014, Arman Uguray wrote: > > On Tue, Dec 9, 2014 at 12:07 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > > Hi Arman, > > > > On Mon, Dec 08, 2014, Arman Uguray wrote: > >> + dev->att = bt_att_ref(g_attrib_get_att(attrib)); > > > > I'd expect a function called "get" to return a new reference, so the > > extra ref() shouldn't be needed. > > > > I see it mostly as a raw getter and adding ref semantics to it seems > confusing to me. Unless we call it g_attrib_get_att_ref or something > to that end. Could be that this is also just because of me spending too much time looking at kernel code. There pretty much everywhere foo_ref() is called foo_get() and foo_unref() is called foo_put(). I thought this was the common behavior for user space *get() functions too, but looking now I could only find agent_get() following this practice. The most annoying thing about your code was really the nested function calls so whatever solution gets rid of that is a step towards the better. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
