Hi Johan, > On Tue, Dec 9, 2014 at 12:07 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Arman, > > On Mon, Dec 08, 2014, Arman Uguray wrote: >> + dev->att = bt_att_ref(g_attrib_get_att(attrib)); > > I'd expect a function called "get" to return a new reference, so the > extra ref() shouldn't be needed. > I see it mostly as a raw getter and adding ref semantics to it seems confusing to me. Unless we call it g_attrib_get_att_ref or something to that end. > Btw, I hope this is just a temporary function that you've introduced to > be able to do the conversions in smaller bits, and that it'll be removed > as soon as the conversions are done? > Pretty much. Basically we have the old code work through the GAttrib shim while the new code work directly through the bt_att that the GAttrib is wrapping. Once all conversions are done, device won't need to include any of the GAttrib code and this function can be removed. Thanks, Arman -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
