Re: [PATCH BlueZ 2/5] gdbus/client.c: don't assume the root object path is valid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Steven,

On Wed, Dec 3, 2014 at 5:54 PM, Steven Walter <stevenrwalter@xxxxxxxxx> wrote:
> We should look for objects at the path the client has registered, not
> hard-coded at root.  In particular, python D-Bus objects will not
> respond to requests directed at the root object path.
> ---
>  gdbus/client.c  | 2 +-
>  src/gatt-dbus.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdbus/client.c b/gdbus/client.c
> index eb68a0f..a270fc2 100644
> --- a/gdbus/client.c
> +++ b/gdbus/client.c
> @@ -1115,7 +1115,7 @@ static void get_managed_objects(GDBusClient *client)
>         if (client->get_objects_call != NULL)
>                 return;
>
> -       msg = dbus_message_new_method_call(client->service_name, "/",
> +       msg = dbus_message_new_method_call(client->service_name, client->base_path,
>                                         DBUS_INTERFACE_DBUS ".ObjectManager",
>                                                         "GetManagedObjects");
>         if (msg == NULL)
> diff --git a/src/gatt-dbus.c b/src/gatt-dbus.c
> index a04c38f..e61af15 100644
> --- a/src/gatt-dbus.c
> +++ b/src/gatt-dbus.c
> @@ -524,7 +524,7 @@ static struct external_service *external_service_new(DBusConnection *conn,
>         GDBusClient *client;
>         const char *sender = dbus_message_get_sender(msg);
>
> -       client = g_dbus_client_new(conn, sender, "/");
> +       client = g_dbus_client_new(conn, sender, path);
>         if (!client)
>                 return NULL;
>
> --
> 1.9.1

I remember the spec had something regarding '/' must be present and
the ObjectManager was only allowed on that because of that otherwise
the clients have to know before hand what path are available which is
the whole point of having ObjectManager to discover that.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux