Re: [PATCH] android/hidhost: Fix logical vs bitwise operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On Friday 21 of November 2014 11:48:50 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> 
> "buf[0] & !1" is always 0, should be bitwise operation.
> ---
>  android/hidhost.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/android/hidhost.c b/android/hidhost.c
> index 75e895b..b696563 100644
> --- a/android/hidhost.c
> +++ b/android/hidhost.c
> @@ -465,7 +465,7 @@ static gboolean ctrl_io_watch_cb(GIOChannel *chan,
> gpointer data) bt_hid_notify_handshake(dev, buf, bread);
>  		break;
>  	case HID_MSG_CONTROL:
> -		if ((buf[0] & !HID_MSG_TYPE_MASK) == HID_VIRTUAL_CABLE_UNPLUG)
> +		if ((buf[0] & ~HID_MSG_TYPE_MASK) == HID_VIRTUAL_CABLE_UNPLUG)
>  			bt_hid_notify_virtual_unplug(dev, buf, bread);
>  		break;
>  	default:

Applied, thanks.

-- 
BR
Szymon Janc
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux