Re: [PATCH 1/1] audio/avrcp: Fix set absolute volume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Nov 24, 2014 at 1:11 PM,  <yes@xxxxxxxxxxx> wrote:
> From: Anurag Biradar <biradar.a@xxxxxxxxxxx>
>
> Player object should be getting from target not from controller
> ---
>  profiles/audio/avrcp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
> index 5c3c4f9..be9cb56 100644
> --- a/profiles/audio/avrcp.c
> +++ b/profiles/audio/avrcp.c
> @@ -1588,7 +1588,7 @@ static uint8_t avrcp_handle_set_absolute_volume(struct avrcp *session,
>                                                 struct avrcp_header *pdu,
>                                                 uint8_t transaction)
>  {
> -       struct avrcp_player *player = session->controller->player;
> +       struct avrcp_player *player = target_get_player(session);
>         uint16_t len = ntohs(pdu->params_len);
>         uint8_t volume;
>
> --
> 1.7.9.5

Absolute volume control works the opposite way, it is the phone/target
that sends it since it want the volume in the headset/controller to
change, this is actually the reason why by enabling volume control PTS
requires to have a controller record since the tests related to
sending commands are tied to controller role for some reason.



-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux