Hi Johannes,
Thanks for your review.
>> +static ssize_t btmrvl_fwdump_read(struct file *file, char __user
>*userbuf,
>> + size_t count, loff_t *ppos)
>> +{
>> + struct btmrvl_private *priv = file->private_data;
>> + ssize_t ret = 0;
>> +
>> + btmrvl_firmware_dump(priv);
>
>Might be better to do that on write.
Sure. We will do this in write handler.
>
>> + fw_dump_len += (strlen("========Start dump ") +
>> + strlen(entry->mem_name) +
>> + strlen("========\n") +
>> + (memory_size + 1) +
>> + strlen("\n========End dump========\n"));
>
>I'd consider a binary file format.
As the dump information is consolidated output for multiple memory segments, we are using start dump and stop dump as delimiter.
>
>You also need the select in the Kconfig as I pointed out before.
Sure.
>
>The more intended use case for this was to trigger it when the driver
>detected a crash, but I guess a debugfs file works as well, just not
>sure when you'd want it.
When user encounters a case when firmware doesn't respond or got hang, firmware dump can be triggered via debugfs command.
Regards,
Amitkumar
��.n��������+%������w��{.n�����{��� �^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
