On Wed, 2014-11-19 at 05:31 -0800, Amitkumar Karwar wrote:
> +static ssize_t btmrvl_fwdump_read(struct file *file, char __user *userbuf,
> + size_t count, loff_t *ppos)
> +{
> + struct btmrvl_private *priv = file->private_data;
> + ssize_t ret = 0;
> +
> + btmrvl_firmware_dump(priv);
Might be better to do that on write.
> + fw_dump_len += (strlen("========Start dump ") +
> + strlen(entry->mem_name) +
> + strlen("========\n") +
> + (memory_size + 1) +
> + strlen("\n========End dump========\n"));
I'd consider a binary file format.
You also need the select in the Kconfig as I pointed out before.
The more intended use case for this was to trigger it when the driver
detected a crash, but I guess a debugfs file works as well, just not
sure when you'd want it.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
