Re: [PATCH 0/4] Bluetooth: More lockdep warning fixes with the help of RCU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

> This patch set converts the LTK and IRK lists to use RCU which
> eliminates the need to always hold the hdev lock while accessing these
> lists. This helps us fix more lockdep warnings arising from hdev locking
> in smp.c.
> 
> What this patch set doesn't fix is the general problem of the SMP
> context holding references to list entries without any guarantee that
> those references stay valid if some other thread goes and removes the
> entries. For this the proper fix would probably be to introduce kref for
> the entries to ensure that external references stay valid. However,
> since that requires considerably more code it's better to first merge
> most lists into a single "remote device info" list that's protected both
> by kref and RCU.
> 
> Johan
> 
> ----------------------------------------------------------------
> Johan Hedberg (4):
>      Bluetooth: Convert LTK list to RCU
>      Bluetooth: Convert IRK list to RCU
>      Bluetooth: Remove unnecessary hdev locking in smp.c
>      Bluetooth: Add debug logs to help track locking issues
> 
> include/net/bluetooth/hci_core.h |  2 +
> net/bluetooth/hci_core.c         | 88 ++++++++++++++++++++++----------------
> net/bluetooth/hci_event.c        |  4 +-
> net/bluetooth/l2cap_core.c       |  3 +-
> net/bluetooth/l2cap_sock.c       | 10 ++++-
> net/bluetooth/smp.c              | 27 ++++--------
> 6 files changed, 75 insertions(+), 59 deletions(-)

all 4 patches have been applied to bluetooth-next tree.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux