Hi Johan,
>> Below are the list of similar patches under 'tools' which are not yet reviewed
>>
>> 1) tools/csr_usb : Fix Resource leak: file
>> 2) tools/hciattach : Fix syntax error
>> 3) tools/btsnoop : Fix variable reassigning issue
>
> This kind of stuff does not belong in a commit message.
>
>> diff --git a/tools/seq2bseq.c b/tools/seq2bseq.c
>> index 7657a57..521d20e 100644
>> --- a/tools/seq2bseq.c
>> +++ b/tools/seq2bseq.c
>> @@ -40,7 +40,7 @@ static int convert_line(int fd, const char *line)
>> char str[3];
>> unsigned char val;
>>
>> - if (line[0] == '*' || line[0] == '\r' || line[0] == '\r')
>> + if (line[0] == '*' || line[0] == '\r')
>> return 0;
>>
>> while (1) {
>
> Are you sure the code wasn't intending to check for '\n'?
yes, it was intended to check for \r and \n. This is my mistake here.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
