Hi, On Wed, Sep 10, 2014, gowtham babu wrote: > The Variable 'written' is reassigned a value before the old one has been used. > The below on fix the same. > --- > tools/btsnoop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/btsnoop.c b/tools/btsnoop.c > index 6ca62d2..86f4691 100644 > --- a/tools/btsnoop.c > +++ b/tools/btsnoop.c > @@ -211,7 +211,7 @@ next_packet: > goto next_packet; > } > > - written = input_pkt[select_input].size = htobe32(toread - 1); > + input_pkt[select_input].size = htobe32(toread - 1); > written = input_pkt[select_input].len = htobe32(toread - 1); Why is there a need to evaluate htobe32(toread - 1) twice here? Why not avoid that by something like: written = htobe32(toread - 1); input_pkt[select_input].size = written; input_pkt[select_input].len = written; Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
