> -----Original Message----- > From: Vikrampal [mailto:vikram.pal@xxxxxxxxxxx] > Sent: Tuesday, August 05, 2014 2:43 PM > To: 'Luiz Augusto von Dentz' > Cc: 'linux-bluetooth@xxxxxxxxxxxxxxx'; 'Dmitry Kasatkin' > Subject: RE: AVCTP and AVRCP packet decoder file structure in btmon > > Hi Luiz, > > If I submit interdependent patches in one go then I guess the patches are > taken in order i.e. 1/4, 2/4, 3/4, 4/4. > > That means we can take just 2/4 out and expect it to compile since it depends * That means we can NOT take just 2/4 out and expect it to compile since it depends > on 1/4. > > Am I correct? > > > -----Original Message----- > > From: Luiz Augusto von Dentz [mailto:luiz.dentz@xxxxxxxxx] > > Sent: Tuesday, August 05, 2014 1:32 PM > > To: Vikrampal > > Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Dmitry Kasatkin > > Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon > > > > Hi Vikrampal, > > > > I do like to test patches individually so please make sure they > > compile and in general we don't allow commits that do not compile > > because they can break bisect. > > > > On Tue, Aug 5, 2014 at 9:54 AM, Vikrampal <vikram.pal@xxxxxxxxxxx> > > wrote: > > > Sure Luiz! > > > > > > However, I've one more small doubt. If I'm submitting a series of > > > patches Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no > > > need to ensure that the patches separately compiles. What we need to > > > ensure is that all the patches together gets compiled properly. Am I > > mistaken? > > > > > >> -----Original Message----- > > >> From: Luiz Augusto von Dentz [mailto:luiz.dentz@xxxxxxxxx] > > >> Sent: Monday, August 04, 2014 4:15 PM > > >> To: Vikrampal > > >> Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Dmitry Kasatkin > > >> Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon > > >> > > >> Hi Vikrampal, > > >> > > >> We can start by reusing avctp.c to place AV/C and AVRCP decoders, > > >> later on we can review if it is the case of splitting. Also please > > >> note that android/Android.mk needs updating if we change anything > > >> on the build of btmon. > > >> > > >> On Mon, Aug 4, 2014 at 11:48 AM, Vikrampal > > <vikram.pal@xxxxxxxxxxx> > > >> wrote: > > >> > Hi, > > >> > > > >> > I'm working on AVRCP packet decoder for Bluetooth monitor module. > > >> > There's a separate file avctp.c/h for AVCTP packet decoder. > > >> > > > >> > The file avctp.c is not a big file as such. So, I'm thinking > > >> > whether or not I should include AVRCP decoder in this file itself. > > >> > > > >> > Shall I create a separate file for AVRCP decoding? > > >> > > > >> > If both AVCTP & AVRCP go in the same file then what should be the > > >> > appropriate name of the file or shall I create a separate file > > >> > for AVRCP as well. > > >> > > > >> > Please advise me. Thanks! > > >> > > > >> > Regards, > > >> > Vikram > > >> > > > >> > > >> > > >> > > >> -- > > >> Luiz Augusto von Dentz > > > > > > Regards, > > > Vikram > > > > > > > > > > > -- > > Luiz Augusto von Dentz > > Regards, > Vikram -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
