Hi Andrei, Szymon,
On Fri, May 9, 2014 at 11:07 AM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@xxxxxxxxx> wrote:
> Hi Szymon,
>
> On Fri, May 09, 2014 at 10:02:11AM +0200, Szymon Janc wrote:
>> Hi,
>>
>> On Friday 09 of May 2014 10:37:27 Andrei Emeltchenko wrote:
>> > Hi Luiz,
>> >
>> > On Thu, May 08, 2014 at 04:22:35PM +0300, Luiz Augusto von Dentz wrote:
>> > > > static bool connect_sco(void)
>> > > > @@ -904,7 +930,7 @@ static bool connect_sco(void)
>> > > > device.negotiated_codec != CODEC_ID_CVSD)
>> > > > voice_settings = BT_VOICE_TRANSPARENT;
>> > > > else
>> > > > - voice_settings = BT_VOICE_CVSD_16BIT;
>> > > > + voice_settings = 0;
>> > >
>> > > What is the reason for changing this value to 0?
>> >
>> > Otherwise we always call setsockopt which fails in old kernels.
>> >
>> > in sco_set():
>> > if (!voice)
>> > return TRUE;
>> >
>> > bt_voice.setting = voice;
>> > if (setsockopt(sock, SOL_BLUETOOTH, BT_VOICE, &bt_voice,
>> > sizeof(bt_voice)) < 0) {
>> > ERROR_FAILED(err, "setsockopt(BT_VOICE)", errno);
>> > return FALSE;
>> > }
>>
>> Mgmt 1.3 is already required by Android bluetoothd (kernel 3.9+) and most
>> likely this dependency will be bumped to 1.4 or 1.5. So I wouldn't worry much
>> about older kernels.
>
> The reason I add this patch was not because I specially like old kernels
> but because this is real use case. What is the default kernel for Android
> 4.4?
Maybe something like the following would solve the problem:
diff --git a/android/handsfree.c b/android/handsfree.c
index b3926f3..1effb05 100644
--- a/android/handsfree.c
+++ b/android/handsfree.c
@@ -896,8 +896,9 @@ static bool connect_sco(void)
if (device.sco)
return false;
- if ((device.features & HFP_HF_FEAT_CODEC) &&
- device.negotiated_codec != CODEC_ID_CVSD)
+ if (!(device.features & HFP_HF_FEAT_CODEC))
+ voice_settings = 0;
+ else if (device.negotiated_codec != CODEC_ID_CVSD)
voice_settings = BT_VOICE_TRANSPARENT;
else
voice_settings = BT_VOICE_CVSD_16BIT;
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
