Re: [PATCHv4 04/12] android/handsfree: Add SCO Audio IPC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

On Thu, May 08, 2014 at 04:22:35PM +0300, Luiz Augusto von Dentz wrote:
> >  static bool connect_sco(void)
> > @@ -904,7 +930,7 @@ static bool connect_sco(void)
> >                                 device.negotiated_codec != CODEC_ID_CVSD)
> >                 voice_settings = BT_VOICE_TRANSPARENT;
> >         else
> > -               voice_settings = BT_VOICE_CVSD_16BIT;
> > +               voice_settings = 0;
> 
> What is the reason for changing this value to 0?

Otherwise we always call setsockopt which fails in old kernels.

in sco_set():
	if (!voice)
		return TRUE;

	bt_voice.setting = voice;
	if (setsockopt(sock, SOL_BLUETOOTH, BT_VOICE, &bt_voice,
						sizeof(bt_voice)) < 0) {
		ERROR_FAILED(err, "setsockopt(BT_VOICE)", errno);
		return FALSE;
	}


Best regards 
Andrei Emeltchenko 

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux