Hi Johan,
On Tue, Apr 29, 2014 at 10:03 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi,
>
> On Tue, Apr 29, 2014, Lukasz Rymanowski wrote:
>> + if (device->server_id)
>> + g_attrib_unregister(device->attrib, device->server_id);
>
> I think the consistent style for async operation id checks is id > 0
Fix in v2
>
>> + dev->server_id = g_attrib_register(attrib, GATTRIB_ALL_REQS,
>> + GATTRIB_ALL_HANDLES,
>> + att_handler, dev, NULL);
>> + if (!dev->server_id)
>> + error("gatt: Could not attache to server");
>
> And id == 0 here
Fix in v2
>
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks
Łukasz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
